Skip to content

Update local model downloading new lines #1163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 25, 2020
Merged

Update local model downloading new lines #1163

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f99ffa3
Update local model downloading new lines
deliahu Jun 25, 2020
a2326b3
Print newline when there are models to be printed
RobertLucian Jun 25, 2020
e199d2a
Merge branch 'master' into local-model-newline
RobertLucian Jun 25, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions cli/local/model_cache.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,10 @@ func CacheModels(apiSpec *spec.API, awsClient *aws.Client) ([]*spec.LocalModelCa
localModelCaches[i].TargetPath = apiSpec.Predictor.Models[i].Name
}

if len(localModelCaches) > 0 {
fmt.Println("") // Newline to group all of the model information
}

return localModelCaches, nil
}

Expand Down Expand Up @@ -128,8 +132,6 @@ func CacheModel(modelPath string, awsClient *aws.Client) (*spec.LocalModelCache,
return nil, err
}

fmt.Println("") // Newline to group all of the model information

localModelCache.HostPath = modelDir

return &localModelCache, nil
Expand Down