Skip to content

Conversation

@RobertLucian
Copy link
Member

@RobertLucian RobertLucian commented Oct 19, 2020

With this in, if the ./dev/config/env.sh environment file is present, it gets exported for the Makefile's shell, and then it runs the specified target. Otherwise, it proceeds with executing the target regardless.

The - symbol before include tells Makefile to ignore a failure/warning and proceed regardless.


checklist:

  • run make test and make lint
  • test manually (i.e. build/push all images, restart operator, and re-deploy APIs)

@RobertLucian RobertLucian added the bug Something isn't working label Oct 19, 2020
@RobertLucian RobertLucian requested a review from deliahu October 19, 2020 18:24
@RobertLucian RobertLucian merged commit 6ecfcc5 into master Oct 21, 2020
@RobertLucian RobertLucian deleted the fix/env-sourcing branch October 21, 2020 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants