Skip to content

Fix document denoiser example (on Keras) #1594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 24, 2020
Merged

Fix document denoiser example (on Keras) #1594

merged 1 commit into from
Nov 24, 2020

Conversation

@RobertLucian
Copy link
Member

@RobertLucian RobertLucian commented Nov 24, 2020 •
edited
Loading

Since h5py isn't locked to a specific version, it was installing the latest version (3.x) of it, which no longer works with Keras 2.3.1. Reverting it to the latest 2.x version fixes the issue. As reported in tensorflow/tensorflow#44467.

checklist:

  • run make test and make lint
  • test manually (i.e. build/push all images, restart operator, and re-deploy APIs)

@RobertLucian RobertLucian added bug Something isn't working example Create or improve an example labels Nov 24, 2020
@RobertLucian RobertLucian merged commit f628fe7 into master Nov 24, 2020
@RobertLucian RobertLucian deleted the fix/document-denoiser-example branch November 24, 2020 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@vishalbollu vishalbollu vishalbollu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

bug Something isn't working example Create or improve an example

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@RobertLucian @vishalbollu