Skip to content

Add debugger makefile command for operator #1662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Dec 8, 2020
Merged

Add debugger makefile command for operator #1662

merged 5 commits into from
Dec 8, 2020

Conversation

@miguelvr
Copy link
Collaborator

@miguelvr miguelvr commented Dec 7, 2020 •
edited
Loading

  • Adds make operator-local-dbg command
  • Excludes some common folders from the linting script (.history and .idea)

checklist:

  • run make test and make lint
  • test manually (i.e. build/push all images, restart operator, and re-deploy APIs)
  • update examples
  • update docs and add any new files to summary.md (view in gitbook after merging)
  • cherry-pick into release branches if applicable
  • alert the dev team if the dev environment changed

@miguelvr
Copy link
Collaborator Author

miguelvr commented Dec 8, 2020

Updated since the GCP merge to master

RobertLucian
RobertLucian approved these changes Dec 8, 2020
View reviewed changes
Copy link
Member

@RobertLucian RobertLucian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Added 2 comments.

@miguelvr
Copy link
Collaborator Author

miguelvr commented Dec 8, 2020

@RobertLucian addressed everything

@miguelvr miguelvr merged commit 8156feb into master Dec 8, 2020
@miguelvr miguelvr deleted the dbg-utils branch December 8, 2020 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RobertLucian RobertLucian RobertLucian approved these changes

@deliahu deliahu Awaiting requested review from deliahu

@vishalbollu vishalbollu Awaiting requested review from vishalbollu

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@miguelvr @RobertLucian