Skip to content

Conversation

@miguelvr
Copy link
Collaborator

@miguelvr miguelvr commented Dec 8, 2020

With the recent GCP merge the make image-<type>-<provider> commands require that all provider specific flags are set in dev/config/env.sh. They can currently be set as empty, but this seems unnecessary.

This PR improves the UX in 2 ways:

  • If building for a specific provider, only that provider's env variables are required (the others do not need to be set)
  • Add validation to check if provider specific env variables are set

checklist:

  • run make test and make lint
  • test manually (i.e. build/push all images, restart operator, and re-deploy APIs)
  • update examples
  • update docs and add any new files to summary.md (view in gitbook after merging)
  • cherry-pick into release branches if applicable
  • alert the dev team if the dev environment changed

Copy link
Member

@RobertLucian RobertLucian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with the exception of 2 nits.

@miguelvr
Copy link
Collaborator Author

miguelvr commented Dec 8, 2020

@RobertLucian addressed your comments on my last commit

@miguelvr miguelvr merged commit 8b0a916 into master Dec 8, 2020
@miguelvr miguelvr deleted the improve-registry-script branch December 8, 2020 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants