Skip to content

Rename tests script param #1757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 4, 2021
Merged

Rename tests script param #1757

merged 4 commits into from
Jan 4, 2021

Conversation

@RobertLucian
Copy link
Member

@RobertLucian RobertLucian commented Jan 4, 2021 •
edited
Loading

s3-bucket is misleading that makes you think of a bucket name such as cortex-examples and not of an S3 path such as s3://cortex-examples/output-dir-for-batch/.

checklist:

  • run make test and make lint
  • test manually (i.e. build/push all images, restart operator, and re-deploy APIs)

miguelvr
miguelvr approved these changes Jan 4, 2021
View reviewed changes
miguelvr
miguelvr reviewed Jan 4, 2021
View reviewed changes
@miguelvr
Copy link
Collaborator

miguelvr commented Jan 4, 2021

LGTM

@RobertLucian RobertLucian merged commit 6160591 into master Jan 4, 2021
@RobertLucian RobertLucian deleted the fix/confusing-param branch January 4, 2021 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@miguelvr miguelvr miguelvr approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@RobertLucian @miguelvr