Check sqs queue length before checking job status #1925
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverting order of operations to check queue length before job status because pods don't automatically terminate if one of the containers terminate. For a TensorFlow batch job, a pod has the batch container and the TF serving container. Even if the batch container exits, the TF serving container still remains running therefore the pod never exits. Since the pod never exists, job.active will be non-zero and the cortex job will remain in the running state.
Revert to checking the length of the queue for now until a better workaround is found.
checklist:
make testandmake lint