Skip to content

Update cluster config arg in e2e tests and nightly build #1945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 9, 2021
Merged

Update cluster config arg in e2e tests and nightly build #1945

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
020191c
Provide cluster config as positional arg
RobertLucian Mar 9, 2021
504318c
Fix .circleci config for AWS/GCP
RobertLucian Mar 9, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ commands:
steps:
- run:
name: Create Cluster
command: cortex cluster up --config << parameters.config >> --configure-env << parameters.provider >> -y
command: cortex cluster up << parameters.config >> --configure-env << parameters.provider >> -y
- run:
name: Run E2E Tests
command: pytest -v test/e2e/tests -k << parameters.provider >> --<< parameters.provider >>-env << parameters.provider >>
Expand All @@ -77,7 +77,7 @@ commands:
steps:
- run:
name: Create Cluster
command: cortex cluster-gcp up --config << parameters.config >> --configure-env << parameters.provider >> -y
command: cortex cluster-gcp up << parameters.config >> --configure-env << parameters.provider >> -y
- run:
name: Run E2E Tests
command: pytest -v test/e2e/tests -k << parameters.provider >> --<< parameters.provider >>-env << parameters.provider >>
Expand Down
3 changes: 1 addition & 2 deletions test/e2e/e2e/cluster.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,9 +38,8 @@ def create_cluster(cluster_config: str):
"cortex",
cluster_cmd,
"up",
"-y",
"--config",
cluster_config,
"-y",
"--configure-env",
f"{cluster_name}-{provider}",
],
Expand Down