Skip to content

Fix cluster configure command #1957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 16, 2021
Merged

Fix cluster configure command #1957

merged 4 commits into from
Mar 16, 2021

Conversation

@RobertLucian
Copy link
Member

@RobertLucian RobertLucian commented Mar 16, 2021 •
edited
Loading

checklist:

  • run make test and make lint
  • test manually (i.e. build/push all images, restart operator, and re-deploy APIs)

vishalbollu
vishalbollu reviewed Mar 16, 2021
View reviewed changes
vishalbollu
vishalbollu approved these changes Mar 16, 2021
View reviewed changes
Copy link
Contributor

@vishalbollu vishalbollu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after switching the index variable

@RobertLucian RobertLucian merged commit e7bacc5 into master Mar 16, 2021
@RobertLucian RobertLucian deleted the fix/cluster-configure branch March 16, 2021 02:54
@vishalbollu vishalbollu added this to the 0.31 milestone Mar 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@vishalbollu vishalbollu vishalbollu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v0.31

Development

Successfully merging this pull request may close these issues.

3 participants

@RobertLucian @vishalbollu