Skip to content

Add AWS region support #203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 5, 2019
Merged

Add AWS region support #203

merged 2 commits into from
Jul 5, 2019

Conversation

@ospillinger
Copy link
Member

@ospillinger ospillinger commented Jul 4, 2019

Closes #

Checklist:

  • Run make test and make lint
  • Test end to end manually (e.g. build/push all images, restart local operator, and run cx refresh in an example folder)
  • Update documentation
  • Update examples
  • Alert team if dev environment changed
  • Cherry-pick into release branches if it's a bugfix
  • Delete the branch once it's merged

@ospillinger ospillinger requested a review from deliahu July 4, 2019 18:43
deliahu
deliahu reviewed Jul 5, 2019
View reviewed changes
docs/cluster/config.md Outdated
# The AWS region Cortex will use
export CORTEX_REGION="us-west-2"

# The AWS zones Cortex will use
Copy link
Member

@deliahu deliahu Jul 5, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the format? comma separated? Can you mention the format and/or give an example?

@ospillinger ospillinger merged commit 1f1c56e into master Jul 5, 2019
@ospillinger ospillinger deleted the aws-region-support branch July 5, 2019 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@deliahu deliahu deliahu approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ospillinger @deliahu