Improve the coverage of the e2e test suite #2069
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobertLucian
changed the title
miguelvr
reviewed
Apr 9, 2021
Comment on lines
+62
to
+64
| pytest -v test/e2e/tests --env aws --skip-autoscaling --skip-load --skip-long-running | ||
| pytest -v test/e2e/tests --env aws -k test_autoscaling | ||
| pytest -v test/e2e/tests --env aws -k test_load |
Collaborator
There was a problem hiding this comment.
this can be summed up to a single command
Member
Author
There was a problem hiding this comment.
That would be ideal - and it is possible, but we'd have to create dependencies (within pytest) between the single-request tests and the load/autoscaling tests. There's no point in letting a load test run if the single-request test failed. I saw this plugin https://pytest-dependency.readthedocs.io/en/stable/usage.html that we could use, but from what I read, this only works for tests that sit in the same module.
The simplest next thing is to just create these "dependencies" by separating the pytest command into multiple ones.
RobertLucian
changed the title
deliahu
approved these changes
Apr 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
checklist:
make testandmake lint