Skip to content

Improve async gateway logging #2070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 12, 2021
Merged

Improve async gateway logging #2070

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2bfdaa6
Improve async gateway logging with tags
Apr 9, 2021
ab67ff1
Merge branch 'master' into improve-async-logging
deliahu Apr 9, 2021
6ccb4ec
Merge branch 'master' into improve-async-logging
RobertLucian Apr 10, 2021
d248e17
Remove unnecessary logging tags
Apr 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion async-gateway/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,6 @@ func main() {
}

s3Storage := NewS3(sess, *bucket)

sqsQueue := NewSQS(*queueURL, sess)

svc := NewService(*clusterName, apiName, sqsQueue, s3Storage, log)
Expand Down
2 changes: 1 addition & 1 deletion async-gateway/service.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ func NewService(clusterName, apiName string, queue Queue, storage Storage, logge
// CreateWorkload enqueues an async workload request and uploads the request payload to S3
func (s *service) CreateWorkload(id string, payload io.Reader, contentType string) (string, error) {
prefix := s.workloadStoragePrefix()
log := s.logger.With(zap.String("id", "id"), zap.String("contentType", contentType))
log := s.logger.With(zap.String("id", id), zap.String("contentType", contentType))

payloadPath := fmt.Sprintf("%s/%s/payload", prefix, id)
log.Debug("uploading payload", zap.String("path", payloadPath))
Expand Down