Skip to content

Add worker label to worker pods to only stream logs from worker pods #2162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 11, 2021
Merged

Add worker label to worker pods to only stream logs from worker pods #2162

merged 3 commits into from
May 11, 2021

Conversation

@vishalbollu
Copy link
Contributor

@vishalbollu vishalbollu commented May 10, 2021

checklist:

  • run make test and make lint
  • test manually (i.e. build/push all images, restart operator, and re-deploy APIs)

@vishalbollu vishalbollu requested review from deliahu and miguelvr May 10, 2021 23:46
miguelvr
miguelvr reviewed May 11, 2021
View reviewed changes
pkg/crds/controllers/batch/batchjob_controller_helpers.go Outdated
"handlerID": apiSpec.HandlerID,
"jobID": batchJob.Name,
"cortex.dev/api": "true",
"worker": "true",
Copy link
Collaborator

@miguelvr miguelvr May 11, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: we could do like async: "cortex.dev/batch": "worker" (for worker) and "cortex.dev/batch": "enqueuer" for enqueuer

@vishalbollu vishalbollu merged commit 9780e27 into master May 11, 2021
@vishalbollu vishalbollu deleted the stream-logs-from-workers-only branch May 11, 2021 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@deliahu deliahu deliahu approved these changes

@miguelvr miguelvr miguelvr approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@vishalbollu @deliahu @miguelvr