Fix make operator-local command #2171
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deliahu
reviewed
May 14, 2021
Member
deliahu
left a comment
deliahu
left a comment
There was a problem hiding this comment.
This looks good to me (@miguelvr do you mind taking a look too?)
Another option could be to download the configmap in operator_local.sh to somewhere in the local file system, and then exporting $CORTEX_CLUSTER_CONFIG_PATH before starting the local operator. Just a thought for you to consider in case you like that approach better.
miguelvr
reviewed
May 17, 2021
miguelvr
approved these changes
May 17, 2021
Collaborator
miguelvr
left a comment
miguelvr
left a comment
There was a problem hiding this comment.
LGTM after you address the comment I left
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running the
make operator-localcommand is failing because the bucket is not available.checklist:
make testandmake lint