Skip to content

Update autofill OnDemandPercentageAboveBaseCapacity to 1 #608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 27, 2019
Merged

Update autofill OnDemandPercentageAboveBaseCapacity to 1 #608

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f98ed5e
Update autofill OnDemandPercentageAboveBaseCapacity to 1
vishalbollu Nov 27, 2019
289aa54
Merge branch 'master' into modify-default-on-demand-percent
vishalbollu Nov 27, 2019
e3e5a91
Update config.md
vishalbollu Nov 27, 2019
5436764
Merge branch 'modify-default-on-demand-percent' of github.com:cortexl…
vishalbollu Nov 27, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions docs/cluster/config.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,8 +52,8 @@ spot_config:
# minimum number of on demand instances (default: 0)
on_demand_base_capacity: 0

# percentage of on demand instances to use after the on demand base capacity has been met [0, 100] (default: 0)
on_demand_percentage_above_base_capacity: 0
# percentage of on demand instances to use after the on demand base capacity has been met [0, 100] (default: 1)
on_demand_percentage_above_base_capacity: 1

# max price for instances (defaults to the on demand price of the primary instance type)
max_price: 0.096
Expand Down
2 changes: 1 addition & 1 deletion pkg/lib/clusterconfig/clusterconfig.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -478,7 +478,7 @@ func (cc *ClusterConfig) AutoFillSpot() error {
}

if spotConfig.OnDemandPercentageAboveBaseCapacity == nil {
spotConfig.OnDemandPercentageAboveBaseCapacity = pointer.Int64(0)
spotConfig.OnDemandPercentageAboveBaseCapacity = pointer.Int64(1)
}

if spotConfig.InstancePools == nil {
Expand Down