Skip to content

Remove regex from tutorial #699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 23, 2019
Merged

Remove regex from tutorial #699

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e07c5b7
Remove regex from tutorial
vishalbollu Dec 20, 2019
0b7ab5f
Merge branch 'master' into remove-regex-from-tutorial
deliahu Dec 21, 2019
ac50b77
Merge branch 'master' into remove-regex-from-tutorial
deliahu Dec 21, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 18 additions & 14 deletions examples/sklearn/iris-classifier/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,16 +61,14 @@ $ python3 trainer.py

import boto3
import pickle
import re

labels = ["setosa", "versicolor", "virginica"]


class PythonPredictor:
def __init__(self, config):
bucket, key = re.match("s3://(.+?)/(.+)", config["model"]).groups()
s3 = boto3.client("s3")
s3.download_file(bucket, key, "model.pkl")
s3.download_file(config["bucket"], config["key"], "model.pkl")

self.model = pickle.load(open("model.pkl", "rb"))

Expand Down Expand Up @@ -117,7 +115,8 @@ Create a `cortex.yaml` file and add the configuration below. A `deployment` spec
python:
predictor: predictor.py
config:
model: s3://cortex-examples/sklearn/iris-classifier/model.pkl
bucket: cortex-examples
key: sklearn/iris-classifier/model.pkl
```

<br>
Expand Down Expand Up @@ -182,7 +181,8 @@ Add a `tracker` to your `cortex.yaml` and specify that this is a classification
python:
predictor: predictor.py
config:
model: s3://cortex-examples/sklearn/iris-classifier/model.pkl
bucket: cortex-examples
key: sklearn/iris-classifier/model.pkl
tracker:
model_type: classification
```
Expand Down Expand Up @@ -224,7 +224,8 @@ This model is fairly small but larger models may require more compute resources.
python:
predictor: predictor.py
config:
model: s3://cortex-examples/sklearn/iris-classifier/model.pkl
bucket: cortex-examples
key: sklearn/iris-classifier/model.pkl
tracker:
model_type: classification
compute:
Expand Down Expand Up @@ -269,7 +270,8 @@ If you trained another model and want to A/B test it with your previous model, s
python:
predictor: predictor.py
config:
model: s3://cortex-examples/sklearn/iris-classifier/model.pkl
bucket: cortex-examples
key: sklearn/iris-classifier/model.pkl
tracker:
model_type: classification
compute:
Expand All @@ -281,7 +283,8 @@ If you trained another model and want to A/B test it with your previous model, s
python:
predictor: predictor.py
config:
model: s3://cortex-examples/sklearn/iris-classifier/another-model.pkl
bucket: cortex-examples
key: sklearn/iris-classifier/another-model.pkl
tracker:
model_type: classification
compute:
Expand Down Expand Up @@ -316,16 +319,14 @@ First, implement `batch-predictor.py` with a `predict` function that can process

import boto3
import pickle
import re

labels = ["setosa", "versicolor", "virginica"]


class PythonPredictor:
def __init__(self, config):
bucket, key = re.match("s3://(.+?)/(.+)", config["model"]).groups()
s3 = boto3.client("s3")
s3.download_file(bucket, key, "model.pkl")
s3.download_file(config["bucket"], config["key"], "model.pkl")

self.model = pickle.load(open("model.pkl", "rb"))

Expand Down Expand Up @@ -355,7 +356,8 @@ Next, add the `api` to `cortex.yaml`:
python:
predictor: predictor.py
config:
model: s3://cortex-examples/sklearn/iris-classifier/model.pkl
bucket: cortex-examples
key: sklearn/iris-classifier/model.pkl
tracker:
model_type: classification
compute:
Expand All @@ -367,7 +369,8 @@ Next, add the `api` to `cortex.yaml`:
python:
predictor: predictor.py
config:
model: s3://cortex-examples/sklearn/iris-classifier/another-model.pkl
bucket: cortex-examples
key: sklearn/iris-classifier/another-model.pkl
tracker:
model_type: classification
compute:
Expand All @@ -380,7 +383,8 @@ Next, add the `api` to `cortex.yaml`:
python:
predictor: batch-predictor.py
config:
model: s3://cortex-examples/sklearn/iris-classifier/model.pkl
bucket: cortex-examples
key: sklearn/iris-classifier/model.pkl
compute:
cpu: 0.5
mem: 1G
Expand Down
4 changes: 1 addition & 3 deletions examples/sklearn/iris-classifier/batch-predictor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,16 +2,14 @@

import boto3
import pickle
import re

labels = ["setosa", "versicolor", "virginica"]


class PythonPredictor:
def __init__(self, config):
bucket, key = re.match("s3://(.+?)/(.+)", config["model"]).groups()
s3 = boto3.client("s3")
s3.download_file(bucket, key, "model.pkl")
s3.download_file(config["bucket"], config["key"], "model.pkl")

self.model = pickle.load(open("model.pkl", "rb"))

Expand Down
9 changes: 6 additions & 3 deletions examples/sklearn/iris-classifier/cortex.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,8 @@
python:
predictor: predictor.py
config:
model: s3://cortex-examples/sklearn/iris-classifier/model.pkl
bucket: cortex-examples
key: sklearn/iris-classifier/model.pkl
tracker:
model_type: classification
compute:
Expand All @@ -20,7 +21,8 @@
python:
predictor: predictor.py
config:
model: s3://cortex-examples/sklearn/iris-classifier/another-model.pkl
bucket: cortex-examples
key: sklearn/iris-classifier/another-model.pkl
tracker:
model_type: classification
compute:
Expand All @@ -32,7 +34,8 @@
python:
predictor: batch-predictor.py
config:
model: s3://cortex-examples/sklearn/iris-classifier/model.pkl
bucket: cortex-examples
key: sklearn/iris-classifier/model.pkl
compute:
cpu: 0.5
mem: 1G
4 changes: 1 addition & 3 deletions examples/sklearn/iris-classifier/predictor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,16 +2,14 @@

import boto3
import pickle
import re

labels = ["setosa", "versicolor", "virginica"]


class PythonPredictor:
def __init__(self, config):
bucket, key = re.match("s3://(.+?)/(.+)", config["model"]).groups()
s3 = boto3.client("s3")
s3.download_file(bucket, key, "model.pkl")
s3.download_file(config["bucket"], config["key"], "model.pkl")

self.model = pickle.load(open("model.pkl", "rb"))

Expand Down