Skip to content

Python serve tweaks #778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 22, 2020
Merged

Python serve tweaks #778

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5dd85ae
Update serve.py
vishalbollu Jan 22, 2020
38b36b7
Do not record prediction if status code is not in 200s
vishalbollu Jan 22, 2020
0174856
Update serve.py
vishalbollu Jan 22, 2020
4f30ab9
Merge branch 'master' into python-serve-tweaks
deliahu Jan 22, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions pkg/workloads/cortex/serve/serve.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ def start(args):
assert_api_version()
storage = S3(bucket=os.environ["CORTEX_BUCKET"], region=os.environ["AWS_REGION"])
try:
raw_api_spec = get_spec(args.cache_dir, args.spec)
raw_api_spec = get_spec(storage, args.cache_dir, args.spec)
api = API(storage=storage, cache_dir=args.cache_dir, **raw_api_spec)
client = api.predictor.initialize_client(args)
cx_logger().info("loading the predictor from {}".format(api.predictor.path))
Expand Down Expand Up @@ -122,7 +122,7 @@ def after_request(response):
try:
api.post_latency_metrics(response.status_code, g.start_time)

if api.tracker is not None:
if int(response.status_code / 100) == 2 and api.tracker is not None:
predicted_value = api.tracker.extract_predicted_value(prediction)
api.post_tracker_metrics(predicted_value)
if predicted_value is not None and predicted_value not in local_cache["class_set"]:
Expand Down Expand Up @@ -164,10 +164,10 @@ def assert_api_version():
)


def get_spec(cache_dir, s3_path):
def get_spec(storage, cache_dir, s3_path):
local_spec_path = os.path.join(cache_dir, "api_spec.msgpack")
bucket, key = S3.deconstruct_s3_path(s3_path)
S3(bucket, client_config={}).download_file(key, local_spec_path)
_, key = S3.deconstruct_s3_path(s3_path)
storage.download_file(key, local_spec_path)
return util.read_msgpack(local_spec_path)


Expand Down