Skip to content

Update insufficient resources error message #919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 27, 2020
Merged

Update insufficient resources error message #919

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1830e10
Update insufficient resources error message
deliahu Mar 27, 2020
7cd34a3
Update errors.go
deliahu Mar 27, 2020
37c0341
Merge branch 'master' into resource-error-msg
deliahu Mar 27, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pkg/operator/operator/errors.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,9 +238,9 @@ func ErrorFieldNotSupportedByPredictorType(fieldKey string, predictorType userco
}

func ErrorNoAvailableNodeComputeLimit(resource string, reqStr string, maxStr string) error {
message := fmt.Sprintf("no available nodes can satisfy the requested %s quantity - requested %s %s but nodes only have %s available %s", resource, reqStr, resource, maxStr, resource)
message := fmt.Sprintf("no instances can satisfy the requested %s quantity - requested %s %s but instances only have %s %s available", resource, reqStr, resource, maxStr, resource)
if maxStr == "0" {
message = fmt.Sprintf("no available nodes can satisfy the requested %s quantity - requested %s %s but nodes don't have any %s", resource, reqStr, resource, resource)
message = fmt.Sprintf("no instances can satisfy the requested %s quantity - requested %s %s but instances don't have any %s", resource, reqStr, resource, resource)
}
return errors.WithStack(&errors.Error{
Kind: ErrNoAvailableNodeComputeLimit,
Expand Down