Improve metrics integration tests #2308
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pracucci
force-pushed
the
improve-metrics-integration-tests
branch
from
4a2667f to
95c7344
Compare
jtlisi
approved these changes
Mar 20, 2020
integration/asserts.go
Outdated
Contributor
There was a problem hiding this comment.
I'm a bit confused where this is coming from?
Contributor
Author
There was a problem hiding this comment.
There's no such metric prefix. I just wanna avoid we'll add it in the future. I think it's a trivial mistake to do.
For example in the past we did a similar mistake with the query frontend and now we have mixed prefixes cortex_query_frontend and cortex_frontend.
Makes sense to you? If it's just my paranoia I can remove this.
Signed-off-by: Marco Pracucci <marco@pracucci.com>
Signed-off-by: Marco Pracucci <marco@pracucci.com>
Signed-off-by: Marco Pracucci <marco@pracucci.com>
Signed-off-by: Marco Pracucci <marco@pracucci.com>
pracucci
force-pushed
the
improve-metrics-integration-tests
branch
from
93c54e2 to
ad2a6aa
Compare
Signed-off-by: Marco Pracucci <marco@pracucci.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
While working on the metrics registration refactoring I've realized the current
integration/metrics_test.gois not that good because doesn't exercise much Cortex code.In this PR I've removed the metrics-specific test and I've added the same assertions to all other integration tests, so that more Cortex code is exercised (ie. chunks storage, blocks storage, caching, ...).
Which issue(s) this PR fixes:
N/A
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]