Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: bump ICS to v4.3.1-lsm #3193

Merged
merged 5 commits into from
Jul 8, 2024
Merged

chore!: bump ICS to v4.3.1-lsm #3193

merged 5 commits into from
Jul 8, 2024

Conversation

sainoe
Copy link
Contributor

@sainoe sainoe commented Jul 5, 2024

Bump ICS to v4.3.1-lsm, which includes the fix introduced in the Gaia v17.3.0 emergency release.

Description

Closes: #XXXX


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • Included the correct type prefix in the PR title
  • Added ! to the type prefix if API, client, or state breaking change (i.e., requires minor or major version bump)
  • Targeted the correct branch (see PR Targeting)
  • Provided a link to the relevant issue or specification
  • Followed the guidelines for building SDK modules
  • Included the necessary unit and integration tests
  • Added a changelog entry in .changelog (for details, see contributing guidelines)
  • Included comments for documenting Go code
  • Updated the relevant documentation or specification
  • Reviewed "Files changed" and left comments if necessary
  • Confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage

@sainoe sainoe marked this pull request as ready for review July 8, 2024 07:18
@@ -0,0 +1,3 @@
- Bump [ICS](https://github.com/cosmos/interchain-security) to
[v4.3.1-lsm](https://github.com/cosmos/interchain-security/releases/tag/v4.3.1-
lsm) ([\#3193](https://github.com/cosmos/gaia/pull/3193))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move -lsm to the previous line? Not sure if this breaks the link.
The same for the state-breaking file.

@sainoe sainoe merged commit cafd702 into main Jul 8, 2024
14 checks passed
@sainoe sainoe deleted the sainoe/main-bump-ics branch July 8, 2024 08:42
mergify bot pushed a commit that referenced this pull request Jul 8, 2024
* backport changelog update from v18.x

* bump ICS to v4.3.1-lsm

* add changelog entries

* remove globalfee from changelog config

(cherry picked from commit cafd702)
sainoe added a commit that referenced this pull request Jul 8, 2024
* backport changelog update from v18.x

* bump ICS to v4.3.1-lsm

* add changelog entries

* remove globalfee from changelog config

(cherry picked from commit cafd702)

Co-authored-by: Simon Noetzlin <simon.ntz@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants