Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removing deps that are no longer needed #781

Merged
merged 1 commit into from
Mar 22, 2021
Merged

removing deps that are no longer needed #781

merged 1 commit into from
Mar 22, 2021

Conversation

shahankhatch
Copy link
Contributor

Closes: #XXX

Description


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented Mar 22, 2021

Codecov Report

Merging #781 (7fbcb7d) into main (269950e) will decrease coverage by 11.97%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #781       +/-   ##
==========================================
- Coverage   12.39%   0.41%   -11.98%     
==========================================
  Files           8       7        -1     
  Lines         694     483      -211     
==========================================
- Hits           86       2       -84     
+ Misses        590     480      -110     
+ Partials       18       1       -17     

@mergify mergify bot merged commit 98f228d into main Mar 22, 2021
@mergify mergify bot deleted the shahan/remove_dep branch March 22, 2021 12:26
mergify bot pushed a commit that referenced this pull request Mar 22, 2021
(cherry picked from commit 98f228d)

# Conflicts:
#	go.sum
shahankhatch added a commit that referenced this pull request Mar 22, 2021
* removing deps no longer needed (#781)

(cherry picked from commit 98f228d)

# Conflicts:
#	go.sum

* go mod tidy

Co-authored-by: Shahan Khatchadourian <shahan.k.code@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants