Skip to content

Fix deployment #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Jan 11, 2022
Merged

Fix deployment #8

merged 13 commits into from
Jan 11, 2022

Conversation

@Speykious
Copy link
Contributor

@Speykious Speykious commented Jan 8, 2022

Finally, we managed to publish this to Nuget!
This PR fixes CI deployment issues once and for all.

@Speykious
Use simple error: Please specify the path to the package.
d136f47 
Usage: dotnet nuget push [arguments] [options]

Arguments:
  [root]  Specify the path to the package and your API key to push the package to the server.

Options:
  -h|--help                      Show help information
  --force-english-output         Forces the application to run using an invariant, English-based culture.
  -s|--source <source>           Package source (URL, UNC/folder path or package source name) to use. Defaults to DefaultPushSource if specified in NuGet.Config.
  -ss|--symbol-source <source>   Symbol server URL to use.
  -t|--timeout <timeout>         Timeout for pushing to a server in seconds. Defaults to 300 seconds (5 minutes).
  -k|--api-key <apiKey>          The API key for the server.
  -sk|--symbol-api-key <apiKey>  The API key for the symbol server.
  -d|--disable-buffering         Disable buffering when pushing to an HTTP(S) server to decrease memory usage.
  -n|--no-symbols                If a symbols package exists, it will not be pushed to a symbols server.
  --no-service-endpoint          Does not append "api/v2/package" to the source URL.
  --interactive                  Allow the command to block and require manual action for operations like authentication.
  --skip-duplicate               If a package and version already exists, skip it and continue with the next package in the push, if any. command
@Speykious
Sync CI workflow with Deploy workflow
4b2e77f
@Speykious
Set package versions to v0.8.9-rc1 for testing
8bcc399
@Speykious
I forgor the source 💀
83f6cf7
@Speykious
Update release text and allow releases
8a64b02
@Speykious
Reset versions to v0.8.9 because everything works
3e18469
@Speykious Speykious added the enhancement New feature or request label Jan 8, 2022
@Speykious Speykious requested a review from sr229 January 8, 2022 16:53
@Speykious Speykious self-assigned this Jan 8, 2022
@Speykious
Copy link
Contributor Author

Speykious commented Jan 8, 2022

Oof, I just realized that I didn't synchronize the CI workflow well. gimme a sec

@Speykious Speykious marked this pull request as draft January 8, 2022 16:55
@Speykious
I forgor the env variables in CI 💀
41e76b7
@Speykious
Add specific conditions for CI build
06edb4a 
Avoid redundant steps, like building both on push and on pull request.
- Do not trigger for any tag, because Deploy builds on release.
- Only trigger push on the master branch, we can't PR master to master.
- Trigger on any pull request, we want to verify that things build.
@Speykious Speykious marked this pull request as ready for review January 8, 2022 18:17
@Speykious
Copy link
Contributor Author

Speykious commented Jan 8, 2022

Well now it does, perfect :D

@adryzz adryzz self-requested a review January 8, 2022 19:21
adryzz
adryzz approved these changes Jan 8, 2022
View reviewed changes
Copy link
Collaborator

@adryzz adryzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, lets wait for ayane

sr229
sr229 requested changes Jan 8, 2022
View reviewed changes
Copy link
Member

@sr229 sr229 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you're planning to actually fix this, then let's have a step for the Production environment, at the moment you're all deploying via the Pre-release environment. Create a dedicated deploy step for the Production environment.

@Speykious
Copy link
Contributor Author

Speykious commented Jan 8, 2022

That's fine, however I don't think we need a dedicated deploy step for production. They'd both be the same without any modification. How about I just edit the environment as environment: ${{ github.event.environment }}?

@sr229
Copy link
Member

sr229 commented Jan 9, 2022

That's fine, however I don't think we need a dedicated deploy step for production. They'd both be the same without any modification. How about I just edit the environment as environment: ${{ github.event.environment }}?

I tried that and it didn't work so the best course of action is hardocde it

@Speykious
Copy link
Contributor Author

Speykious commented Jan 11, 2022

Awesome! It looks like ${{ github.event.release.prerelease && 'Pre-release' || 'Production' }} is a perfect fit.
The Production deployment "error" up there is just me cancelling it - we've already published the packages.

@Speykious
Reset version to v0.8.9
6d73a2a 
Testing has been a success!
Reflecting back, I shouldn't even have changed the version to test.
Eh, doesn't really matter anymore.
@Speykious Speykious merged commit 09a7175 into master Jan 11, 2022
@Speykious Speykious deleted the deploy branch January 11, 2022 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sr229 sr229 sr229 approved these changes

@adryzz adryzz adryzz approved these changes

Assignees

@Speykious Speykious

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Speykious @sr229 @adryzz