Skip to content

Conversation

@Aloren
Copy link
Contributor

@Aloren Aloren commented Dec 12, 2018

Update maven plugins:

  • maven-compiler-plugin.version 3.8.0
  • maven-jar-plugin.version 3.1.0
  • maven-shade-plugin.version 3.2.0
  • maven-resources-plugin.version 3.1.0

Relocate shaded dependencies into couchbase.mock package

@avsej Please review. I've found your commit with revert of plugins update, but I could not find out what was the issue with the change.

@cb-sdk-robot
Copy link

Thanks for the pull request!! To ensure quality review, Couchbase employs a code review system based on Gerrit to manage the workflow of changes in addition to tracking our contributor agreements.

Your changes (commit: ff2186e) have been pushed to the Couchbase Review Site:
http://review.couchbase.org/102748

::SDKBOT/PR:created

@avsej
Copy link
Member

avsej commented Dec 13, 2018

Thanks @Aloren. I left review comments on gerrit. To update commit there you can do something like:

git remote add gerrit ssh://YOURGERRITNAME@review.couchbase.org:29418/CouchbaseMock
git fetch gerrit refs/changes/48/102748/2 && git checkout FETCH_HEAD

then make fixes, amend top commit and upload for review

git add .
git commit --amend
git push gerrit HEAD:refs/for/master

maven-compiler-plugin.version 3.8.0
maven-jar-plugin.version 3.1.0
maven-shade-plugin.version 3.2.0
maven-resources-plugin.version 3.1.0
Relocate shaded dependencies into com.couchbase.mock.deps package

Fixes couchbase#45, couchbase#33
@cb-sdk-robot
Copy link

Your changes (commit: 9bb30f0) have been pushed to the Couchbase Review Site:
http://review.couchbase.org/102748

::SDKBOT/PR:updated

@Aloren
Copy link
Contributor Author

Aloren commented Dec 13, 2018

@avsej looks like @cb-sdk-robot does that job better than me :D

@Aloren
Copy link
Contributor Author

Aloren commented Dec 13, 2018

@avsej should i check something specific since all maven plugins were updated?

@cb-sdk-robot
Copy link

This Pull Request has been closed as the associated Gerrit change was merged.

::SDKBOT/PR:merged

ns-codereview pushed a commit that referenced this pull request Dec 13, 2018
maven-compiler-plugin.version 3.8.0
maven-jar-plugin.version 3.1.0
maven-shade-plugin.version 3.2.0
maven-resources-plugin.version 3.1.0
Relocate shaded dependencies into com.couchbase.mock.deps package

Fixes #45, #33

Change-Id: Ia098e2207df0b54e569bd18e3fb0961a17f81b44
Reviewed-on: http://review.couchbase.org/102748
Reviewed-by: Sergey Avseyev <sergey.avseyev@gmail.com>
Tested-by: Sergey Avseyev <sergey.avseyev@gmail.com>
@avsej
Copy link
Member

avsej commented Dec 13, 2018

thank you, @Aloren

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants