Skip to content

Conversation

@sarahlwelton
Copy link
Contributor

Updated the code for the Threshold Tracer to reflect the proper thresholdOption name.

There was no fix version on the ticket, so I don't know which versions this change might need to be copied back to. Logging against most recent release for now.

@sarahlwelton sarahlwelton added bug Something isn't working question Further information is requested labels Sep 2, 2022
@sarahlwelton sarahlwelton requested a review from a team September 2, 2022 16:36
@sarahlwelton sarahlwelton self-assigned this Sep 2, 2022
@maria-robobug
Copy link
Contributor

Yep, going with latest is sound! It looks like this method was renamed from SDK 3.2 onwards.
So will be good to backport this fix forrelease/3.2 as well, as seen in the SDK 3.2 API doc.

As for release/3.1, we can stick with WithInterval

For release/3.0, from what I can see in the 3.0 SDK API docs, ThresholdOptions probably was not available at the time (can't find any reference to it), so we can leave that as is also.

Copy link
Contributor

@maria-robobug maria-robobug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 LGTM!

@maria-robobug maria-robobug merged commit c389c1f into release/3.3 Sep 5, 2022
@maria-robobug maria-robobug deleted the DOC-9517 branch September 5, 2022 09:27
sarahlwelton added a commit that referenced this pull request Sep 6, 2022
DOC-9517 - Backport PR #274 - Updated thresholdOptions.WithInterval to thresholdOptions.WithEmitInterval
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working question Further information is requested

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants