Skip to content

Conversation

@jeffrymorris
Copy link
Contributor

No description provided.

Copy link

@dnault dnault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I can't remember whose idea this was (Richard? Hakim? Maria?), but over in Java-land we've been trying to phrase the release notes as positives instead of negatives. In other words, describing the improvement instead of the flaw.

For example, instead of "Search: Min function throws an exception if the argument is > 0", we could say:

When using a DisjunctionQuery in a full-text search, it's now possible to specify the minimum number of sub-queries that must be satisfied. (Previously, DisjunctionQuery.Min() would always throw ArgumentOutOfRangeException.)

[#version-3-4-1]
== Version 3.4.1 (09 December 2022)

Version 3.4.1 is the second release of the 3.4 series.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NIT: This is information-free :-) Omit it if you want.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks David - this bit is as much visual pause as orientation, for those skimming quickly.


=== Fixed Issues

* https://issues.couchbase.com/browse/NCBC-3204[NCBC-3204]: CombinationTest failure: Test_GetAndLockAsync_Locked
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NIT: If the fix was to change/disable the test, is it release note-worthy?

@RichardSmedley
Copy link
Contributor

LGTM.

I can't remember whose idea this was (Richard? Hakim? Maria?), but over in Java-land we've been trying to phrase the release notes as positives instead of negatives. In other words, describing the improvement instead of the flaw.

Thanks David - we've asked for this before, but the .NET team doesn't have the resources at present.

One workaround we've discussed with @raycardillo is a compulsory release notes field in JIRA, so that the text can be filled out when closing an issue - whilst the knowledge is fresh in the engineer's mind.

@RichardSmedley RichardSmedley merged commit 8affcf2 into couchbase:release/3.4 Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants