Skip to content

Conversation

@jeffrymorris
Copy link
Contributor

No description provided.

@jeffrymorris
Copy link
Contributor Author

@RichardSmedley - can this be merged or should I ping someone else?

Thanks,
Jeff

@RichardSmedley
Copy link
Contributor

@RichardSmedley - can this be merged or should I ping someone else?

Thanks, Jeff

You pushed it at a weekend, without pinging me on Slack (or adding me as a reviewer) - and I've been task-focussed all week, ignoring my e-mail backlog ;)

Will look at it now 👍

Copy link
Contributor

@RichardSmedley RichardSmedley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jeffrymorris
Will merge this now, but please check the changes that I have made, to ensure that the wording matches the intent of the fixes.

@RichardSmedley RichardSmedley merged commit 149a9af into couchbase:release/3.4 Mar 15, 2023
@jeffrymorris
Copy link
Contributor Author

@jeffrymorris

Thanks! I don't have rights to assign you as a reviewer for some reason.

Jeff

@RichardSmedley
Copy link
Contributor

Thanks! I don't have rights to assign you as a reviewer for some reason.

Jeff

Ah - looks like you'll need @ingenthr or @brett19 to add you to https://github.com/orgs/couchbase/teams/sdk-maintainers/members - then you should be able to 👍

@ingenthr
Copy link
Contributor

Added you @jeffrymorris.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants