Skip to content

Conversation

@maria-robobug
Copy link
Contributor

@maria-robobug maria-robobug commented Mar 30, 2022

  • Use changes made in this sdk-common PR:
    DOC-9567 - Add shared SDK index management sections docs-sdk-common#47

  • Add Index management examples with scopes and collections (new in 3.3)

  • Fill in examples that were missing/commented out, apart from Views.
    Let me know if I should add some views examples in though,
    I just thought we generally don't want to mention too much about them in the docs,
    assuming that they will be gone in some distant future...
    UPDATE: Views examples added!

- Use changes made in this sdk-common PR:
  couchbase/docs-sdk-common#47

- Add Index management examples with scopes and collections (new in 3.3)

- Fills in examples that were missing/commented out, apart from Views.
  Let me know if I should add some views examples in though,
  I just thought we generally don't want to mention too much about them in the docs,
  assuming that they will be gone in some distant future...
@RichardSmedley
Copy link
Contributor

LGTM but will hold off approval for a proper code review from the others 👍

@maria-robobug
Copy link
Contributor Author

Ignore failing build for now, it's because Graham moved the pom.xml, I'll update this when I have a bit of time.

Copy link
Collaborator

@osfameron osfameron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@maria-robobug maria-robobug merged commit 24ffe89 into couchbase:release/3.3 Apr 12, 2022
@maria-robobug maria-robobug deleted the DOC-9567 branch April 12, 2022 09:37
programmatix pushed a commit to programmatix/docs-sdk-java that referenced this pull request Apr 26, 2022
* DOC-9567 - Add scoped index management examples

- Use changes made in this sdk-common PR:
  couchbase/docs-sdk-common#47

- Add Index management examples with scopes and collections (new in 3.3)

- Fills in examples that were missing/commented out, apart from Views.
  Let me know if I should add some views examples in though,
  I just thought we generally don't want to mention too much about them in the docs,
  assuming that they will be gone in some distant future...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants