-
Notifications
You must be signed in to change notification settings - Fork 39
DOC-9567 - Add scoped index management examples #317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use changes made in this sdk-common PR: couchbase/docs-sdk-common#47 - Add Index management examples with scopes and collections (new in 3.3) - Fills in examples that were missing/commented out, apart from Views. Let me know if I should add some views examples in though, I just thought we generally don't want to mention too much about them in the docs, assuming that they will be gone in some distant future...
Contributor
|
LGTM but will hold off approval for a proper code review from the others 👍 |
maria-robobug
commented
Mar 30, 2022
Contributor
Author
|
Ignore failing build for now, it's because Graham moved the |
osfameron
reviewed
Apr 12, 2022
osfameron
approved these changes
Apr 12, 2022
Collaborator
osfameron
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
programmatix
pushed a commit
to programmatix/docs-sdk-java
that referenced
this pull request
Apr 26, 2022
* DOC-9567 - Add scoped index management examples - Use changes made in this sdk-common PR: couchbase/docs-sdk-common#47 - Add Index management examples with scopes and collections (new in 3.3) - Fills in examples that were missing/commented out, apart from Views. Let me know if I should add some views examples in though, I just thought we generally don't want to mention too much about them in the docs, assuming that they will be gone in some distant future...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use changes made in this sdk-common PR:
DOC-9567 - Add shared SDK index management sections docs-sdk-common#47
Add Index management examples with scopes and collections (new in 3.3)
Fill in examples that were missing/commented out, apart from Views.
Let me know if I should add some views examples in though,
I just thought we generally don't want to mention too much about them in the docs,
assuming that they will be gone in some distant future...
UPDATE: Views examples added!