Skip to content

Conversation

@maria-robobug
Copy link
Contributor

@maria-robobug maria-robobug commented Apr 11, 2022

Use changes made in this sdk-common PR:
couchbase/docs-sdk-common#47

Add Index management examples with scopes and collections (new in 3.3)

@maria-robobug maria-robobug changed the title Add scoped index management examples [DOC-9567] - Add scoped index management examples Apr 11, 2022
Copy link
Contributor

@thejcfactor thejcfactor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

:page-toclevels: 2

// API refs
:bucket-api-reference: pass:q[BucketManager -- https://pkg.go.dev/github.com/couchbase/gocb/v2?tab=doc#Cluster.Buckets[`Cluster.buckets()`]]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a thought (I realise this is already in -common, so not requesting a change now) but might it be more useful to store the URL / URL + description separately from the "BucketManager --" text? hmm... well, not important anyway.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, I think it would be nice to actually have a separate improvements ticket for API docs references.
So maybe we can collate all this there, and cleanup how we use these variables.
Maybe we can chat about it on a Friday meeting.

Copy link
Collaborator

@osfameron osfameron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 minor ting inline

@maria-robobug maria-robobug merged commit 6179026 into couchbase:release/4.0 Apr 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants