Skip to content

Conversation

@maheshnagarajCbase
Copy link
Contributor

PR for Alice Staging build
@amarantha-k pls review and merge this changes.

amarantha-k and others added 21 commits September 11, 2018 11:54
* Incorporating feedback

* Incorporating feedback

* incorporating feedback

* Incorporate feedback

* Incorporating feedback

* Incorporating feedback

* Incorporate feedback
Merging branch DOC-4019 with DOC-4306 for staging build
Merging branch DOC-4084 timers consolidation content with DOC-4306
Merging remote branch Doc-4083 to Doc-4306 for the stating build
@maheshnagarajCbase
Copy link
Contributor Author

@amarantha-k : PR - Doc 4306 #34 for your review.

*Debugging a Function Using the Debug Option*

. From the *Couchbase Web Console* > *Eventing* page, click on the name of a deployed Function.
=== *Debugging a Function Using the Debug Option*
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't need to bold a heading

From the Debugging pop-up, click *Stop Debugging* to terminate a debug session.
. From the Debugging pop-up, click *Stop Debugging* to terminate a debug session.

=== *Transpiler and Source Map*
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't need to bold headings

image::debug_sourcemap.png[,600]

[#modifydebugport]
=== *Modifying the Debug Port*
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't need to bold headings

For log rotation, refer to xref:clustersetup:ui-logs.adoc[Using Logs].

*Application Logs*
=== *Application Logs*
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't need to bold headings


[abstract]
Some questions, frequently asked about the Eventing service and Functions.
Some questions, frequently asked about the Eventing Service and Functions.``
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reword the abstract. Maybe add info on why the user should look at FAQs.

+
Javascript is the language to be used while creating Functions.
Node modules cannot be imported: only simple Javascript can be used.
== *Generic*
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't need to bold headings


+
Eventing leverages the latest trends in multi-core CPUs; therefore nodes selected for Eventing should optimally have a higher number of cores than those for indexing.
No. We do not support versioning of documents; therefore, this feature is not available out of the box. Though customers can have another ‘Mother’ bucket that stores documents that could be looked up, in order to determine the difference between the current document and the last modified.
Copy link
Contributor

@amarantha-k amarantha-k Oct 24, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we define a "Mother" bucket somewhere else? Also, need to rewrite the sentence for second person.

+
No.
Functions do not lose any mutations during a rebalance operations.
== *Cluster Behaviour*
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Behavior (US English)



* What is the Timer behavior post reboot?
* What is the behaviour of system clocks while using timers?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

behavior

[#timers]
== Timers

Author's Note: The Timer content to be removed
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the author's note?

Copy link
Contributor

@amarantha-k amarantha-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added comments for a few instances. Please review and apply to all headings.

@maheshnagarajCbase
Copy link
Contributor Author

@amarantha-k incorporated feedback. Globally, ran a check to fix the bold headings across eventing sections.


+
No. We do not support versioning of documents; therefore, this feature is not available out of the box. Though customers can have another ‘Mother’ bucket that stores documents that could be looked up, in order to determine the difference between the current document and the last modified.
No. We do not support versioning of documents; therefore, this feature is not available out of the box. Though customers can have another bucket, say ‘Mother’ bucket, that stores documents that could be looked up, to determine the difference between the current document and the last modified.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Address the user as "you" rather than customer. Also, based on the context, a 'Mother' bucket seems to be a parent bucket that contains the version of documents before the current set of changes. You may want to clarify this with an SME.

Copy link
Contributor

@amarantha-k amarantha-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the comment in eventing-faq.adoc and then we should be good to merge this PR.

@amarantha-k amarantha-k merged commit c53b974 into couchbase:release/6.0 Oct 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants