Skip to content

Conversation

@julia-cb
Copy link
Contributor

@julia-cb julia-cb commented Mar 14, 2024

Moved Eventing nav to a partial in the docs-devex repo.

docs-devex PR: couchbaselabs/docs-devex#151
preview site: https://preview.docs-test.couchbase.com/eventingnav/server/current/eventing/eventing-overview.html

@julia-cb
Copy link
Contributor Author

@osfameron @simon-dew Hey guys, I moved the Eventing nav to docs-devex here and added the new partial file path to the nav.adoc file in this PR. Can you take a look and let me know if I did it properly? I don't want to merge it and break staging by accident lol. Thanks!

Copy link
Contributor

@simon-dew simon-dew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to approve this but please do a preview build to check that it works.

** xref:sdk:sdk-doctor.adoc[Troubleshooting Connections with SDK Doctor]
include::n1ql:partial$nav.adoc[]

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about adding blank lines in the navigation list, they're fickle things, and the blank lines may have unwanted effects on the indenting of included partials. Have you done a preview build to check that it all works?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked the navigation for Search and Query and everything works! I'll go ahead and merge this PR.

Preview here: https://preview.docs-test.couchbase.com/eventingnav/server/current/eventing/eventing-overview.html

@julia-cb julia-cb merged commit 8933963 into release/7.6 Mar 16, 2024
@julia-cb julia-cb deleted the DOC-11930_EventingNavBarServer branch March 16, 2024 01:16
@julia-cb julia-cb restored the DOC-11930_EventingNavBarServer branch March 16, 2024 07:44
julia-cb added a commit that referenced this pull request Mar 16, 2024
julia-cb added a commit that referenced this pull request Mar 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants