-
Notifications
You must be signed in to change notification settings - Fork 95
Info Banner - Capella Spring Release #690
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@sarahlwelton feel free to push any CSS changes! (I'll also need to extract them to docs-ui in due course, but inlined here is slightly easier to iterate for POC) |
As long as we make sure to undo this - inline CSS is already making me nervous! 😱 |
sarahlwelton
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm picky and want to see the text minorly tweaked for grammar, and I've added my CSS. We can discuss further from here - I'm assuming we didn't hear anything from marketing regarding gradient vs. my style?
|
Thanks @sarahlwelton - I've not heard back from Marketing, but @bfavini may have info? I feel like the styling looks more classy (yay) but also feels a bit less noticeable? The hover-over button effect is great! I shoulda done that, was lazy of me. BUT it wiggles the box by a pixel which is messy. Can you get that fixed, and then we can get it built into staging. |
|
As @bfavini / marketing had approved earlier versions, reverted @sarahlwelton's CSS changes, sorry! Those are saved to capella-spring-release-banner-css for future reference. |
RichardSmedley
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
| } | ||
| .info-banner a:hover { | ||
| text-decoration: none; | ||
| border: none; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| border: none; | |
| border: none; |
I think this might be causing the banner to shift on hover.
95eed55 to
bb81b24
Compare
This is currently on docs-staging.
Note that Cloud and Cloud Native don't show it, because their landing pages are defined in separate projects.
PRs:
https://github.com/couchbase/docs-cloud-native/pull/26
https://github.com/couchbasecloud/couchbase-cloud/pull/21528