Skip to content

Conversation

@osfameron
Copy link
Collaborator

@osfameron osfameron commented May 30, 2023

This is currently on docs-staging.

Note that Cloud and Cloud Native don't show it, because their landing pages are defined in separate projects.
PRs:

https://github.com/couchbase/docs-cloud-native/pull/26
https://github.com/couchbasecloud/couchbase-cloud/pull/21528

@osfameron osfameron requested review from bfavini and sarahlwelton May 30, 2023 15:50
@osfameron
Copy link
Collaborator Author

@sarahlwelton feel free to push any CSS changes!

(I'll also need to extract them to docs-ui in due course, but inlined here is slightly easier to iterate for POC)

@sarahlwelton
Copy link
Contributor

@sarahlwelton feel free to push any CSS changes!

(I'll also need to extract them to docs-ui in due course, but inlined here is slightly easier to iterate for POC)

As long as we make sure to undo this - inline CSS is already making me nervous! 😱

Copy link
Contributor

@sarahlwelton sarahlwelton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm picky and want to see the text minorly tweaked for grammar, and I've added my CSS. We can discuss further from here - I'm assuming we didn't hear anything from marketing regarding gradient vs. my style?

@osfameron
Copy link
Collaborator Author

Thanks @sarahlwelton - I've not heard back from Marketing, but @bfavini may have info?

I feel like the styling looks more classy (yay) but also feels a bit less noticeable?
Anyway, I'll merge so Beth/marketing can chime in, BUT:

The hover-over button effect is great! I shoulda done that, was lazy of me. BUT it wiggles the box by a pixel which is messy. Can you get that fixed, and then we can get it built into staging.

@osfameron
Copy link
Collaborator Author

As @bfavini / marketing had approved earlier versions, reverted @sarahlwelton's CSS changes, sorry! Those are saved to capella-spring-release-banner-css for future reference.

@osfameron osfameron marked this pull request as ready for review June 1, 2023 12:36
Copy link
Contributor

@RichardSmedley RichardSmedley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

}
.info-banner a:hover {
text-decoration: none;
border: none;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
border: none;
border: none;

I think this might be causing the banner to shift on hover.

@osfameron osfameron force-pushed the capella-spring-release-banner branch from 95eed55 to bb81b24 Compare June 1, 2023 13:00
@osfameron osfameron merged commit 62f1f76 into master Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants