Skip to content

Conversation

@osfameron
Copy link
Collaborator

No description provided.

@osfameron osfameron merged commit 0944f0d into staging Jun 6, 2023
yarn global add --ignore-optional --silent git+https://gitlab.com/opendevise/oss/antora-site-generator-ms#as-extension && \
yarn global add --ignore-optional --silent asciidoctor-kroki && \
yarn global add --ignore-optional --silent asciidoctor-external-callout@1.2.0 && \
yarn global add --ignore-optional --silent https://yarn.pm/@asciidoctor/tabs && \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Asciidoctor Tabs dependency should not be prefixed with https://yarn.pm/.

@osfameron
Copy link
Collaborator Author

Indeed! I don't know yarn at all, was trying to copy/paste from the yarn modules site to get it right, and misunderstood what to paste... (it's fixed in a subsequent commit after this PR)

Do you remember the reason we use npm locally and yarn on the builds?
Is there any disadvantage to standardising on one OR the other for both?

@mojavelinux
Copy link
Contributor

Antora's container uses yarn, so it's currently required since this container extends that one. In Antora, we're in the very slow process of moving away from Yarn, but we've not had ample time to complete the transition. Hence, we're stuck using yarn in one case and npm in another. Though, in the end, it really doesn't matter what is used since they do exactly the same thing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants