DOC-13343 call allOf recursively #852
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the handling of nested allOf schemas in OpenAPI specifications by making the child_entries function recursive. Previously, only top-level properties within allOf were extracted; now nested allOf structures are properly flattened.
- Modified
child_entriesto recursively processallOfschemas instead of only extracting direct properties - Added test coverage for nested
allOfscenarios - Updated test fixture to reflect the corrected output for nested schema structures
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| lib/helpers/lib/each-openapi-module.js | Changed via_allOf to recursively call child_entries instead of directly accessing properties |
| test/test-each-openapi.js | Added test case verifying recursive allOf processing works correctly |
| test/fixtures/toc-bootstrap.html | Updated fixture with previously missing console logging configuration entries now properly extracted |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
looks good
|
| a => Object.entries(a.properties || {})) || [] | ||
| // allOf can be nested, so call child_entries recursively | ||
| const via_allOf = (node.allOf || []).flatMap(subNode => | ||
| child_entries(subNode) |
There was a problem hiding this comment.
Huh, it actually was that easy...
I was very much "can't program my way out of a paper bag" last time I looked at this...
Thanks for taking this on!
There was a problem hiding this comment.
I used AI to ask how I would do this in js based on how I would do this in another language.
2 participants
I didn't preview with the actual docs site, which would be good to verify but this looks right in the test.