Skip to content

DOC-12226 disambiguate code links #182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 3, 2024
Merged

DOC-12226 disambiguate code links #182

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/css/base.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,11 @@ code {
color: var(--color-brand-gray1);
}

a code {
color: var(--color-link);
background-color: transparent;
Copy link
Contributor

@simon-dew simon-dew Jun 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait, so what does it look like if you have a longer run of inline code and only some of it is a link? Does the link lose its background even though the rest of the code has a shaded background?

<code>I'm code! <a href="example.com">And I'm a link!</a> But I am not!</code>

Copy link
Contributor Author

@osfameron osfameron Jun 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did check this for e.g. code listings with links, possibly locally (I think there is an example in Server docs I'll try to dig up).

That wasn't a problem because, as in your snippet above, it's code a whereas the CSS only applies to a code 👍

Copy link
Contributor

@simon-dew simon-dew Jun 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah what I'm thinking of is probably an edge case. This PR fixes the immediate problem. LGTM

}

html code {
hyphens: none;
}
Expand Down