TRACE_EVENT0 to invoke TRACE_START_EVENT0 #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: Ie9ed5b6e7aa58d2a0ab295ef8e99d5b299af9a34
ns-codereview
pushed a commit
that referenced
this pull request
Aug 16, 2016
By having the group_count load in CategoryRegistry::getStatus
be memory_order_acquire we avoid a benign TSan race (TSan
cannot introspect that group_count is always valid even when
stale so requires the memory barrier to force it to realise
it's always valid).
WARNING: ThreadSanitizer: data race (pid=90501)
Read of size 8 at 0x7d0c00005028 by thread T4 (mutexes: write M4934):
#0 strcmp <null> (memcached+0x0000004781d0)
#1 phosphor::CategoryRegistry::getStatus(char const*) /home/couchbase/jenkins/workspace/memcached-threadsanitizer-master/phosphor/src/category_registry.cc:40 (libphosphor.so+0x0000000072f2)
#2 phosphor::TraceLog::getCategoryStatus(char const*) /home/couchbase/jenkins/workspace/memcached-threadsanitizer-master/phosphor/src/trace_log.cc:359 (libphosphor.so+0x0000000130e5)
#3 McbpConnection::runStateMachinery() /home/couchbase/jenkins/workspace/memcached-threadsanitizer-master/memcached/daemon/connection_mcbp.cc:997 (memcached+0x0000004ff393)
#4 McbpConnection::runEventLoop(short) /home/couchbase/jenkins/workspace/memcached-threadsanitizer-master/memcached/daemon/connection_mcbp.cc:1274 (memcached+0x000000500800)
#5 run_event_loop /home/couchbase/jenkins/workspace/memcached-threadsanitizer-master/memcached/daemon/connections.cc:153 (memcached+0x0000005021c6)
#6 event_handler(int, short, void*) /home/couchbase/jenkins/workspace/memcached-threadsanitizer-master/memcached/daemon/memcached.cc:941 (memcached+0x0000004d19b3)
#7 event_base_loop <null> (libevent_core-2.0.so.5+0x00000000b357)
#8 platform_thread_wrap(void*) /home/couchbase/jenkins/workspace/memcached-threadsanitizer-master/platform/src/cb_pthreads.cc:54 (libplatform.so.0.1.0+0x00000000586b)
Previous write of size 8 at 0x7d0c00005028 by thread T3 (mutexes: write M4931, write M5242):
#0 operator new(unsigned long) <null> (memcached+0x00000046993d)
#1 <null> <null> (libstdc++.so.6+0x0000000c0568)
#2 phosphor::TraceLog::getCategoryStatus(char const*) /home/couchbase/jenkins/workspace/memcached-threadsanitizer-master/phosphor/src/trace_log.cc:359 (libphosphor.so+0x0000000130e5)
#3 McbpConnection::runStateMachinery() /home/couchbase/jenkins/workspace/memcached-threadsanitizer-master/memcached/daemon/connection_mcbp.cc:997 (memcached+0x0000004ff393)
#4 McbpConnection::runEventLoop(short) /home/couchbase/jenkins/workspace/memcached-threadsanitizer-master/memcached/daemon/connection_mcbp.cc:1274 (memcached+0x000000500800)
#5 run_event_loop /home/couchbase/jenkins/workspace/memcached-threadsanitizer-master/memcached/daemon/connections.cc:153 (memcached+0x0000005021c6)
#6 event_handler(int, short, void*) /home/couchbase/jenkins/workspace/memcached-threadsanitizer-master/memcached/daemon/memcached.cc:941 (memcached+0x0000004d19b3)
#7 event_base_loop <null> (libevent_core-2.0.so.5+0x00000000b357)
#8 platform_thread_wrap(void*) /home/couchbase/jenkins/workspace/memcached-threadsanitizer-master/platform/src/cb_pthreads.cc:54 (libplatform.so.0.1.0+0x00000000586b)
Change-Id: I80c52ccf9467b5c9f6b836d1ff4f961d3cb094ce
Reviewed-on: http://review.couchbase.org/66796
Tested-by: buildbot <build@couchbase.com>
Reviewed-by: Dave Rigby <daver@couchbase.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change-Id: Ie9ed5b6e7aa58d2a0ab295ef8e99d5b299af9a34