[DOC-12618]: Feedback on Language Constructs | Couchbase Docs #292
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RayOffiah
added
bug
RayOffiah
force-pushed
the
DOC-12618-Feedback-on-Language-Constructs-Couchbase-Docs
branch
from
2dcdfb2 to
333b63d
Compare
RayOffiah
force-pushed
the
DOC-12618-Feedback-on-Language-Constructs-Couchbase-Docs
branch
from
333b63d to
ed971c6
Compare
AnkitPrabhu
reviewed
Nov 20, 2024
|
[like] Ray Offiah reacted to your message:
…________________________________
From: AnkitPrabhu ***@***.***>
Sent: Wednesday, November 20, 2024 2:20:20 PM
To: couchbaselabs/docs-devex ***@***.***>
Cc: Ray Offiah ***@***.***>; Assign ***@***.***>
Subject: Re: [couchbaselabs/docs-devex] [DOC-12618]: Feedback on Language Constructs | Couchbase Docs (PR #292)
@AnkitPrabhu commented on this pull request.
It does not include the enclosing quotation marks from the parameter in the translation if its parameter type is string. Other datatypes works as crc64 call.
—
Reply to this email directly, view it on GitHub<#292 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ASL3EZ7CGQHEKIBFULODODD2BSLCJAVCNFSM6AAAAABR67UQA2VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDINBYG43DEMRVGA>.
You are receiving this because you were assigned.Message ID: ***@***.***>
[DOC-12618]: https://couchbasecloud.atlassian.net/browse/DOC-12618?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
|
Corrected grammar. Added `crc_go_iso` function.
RayOffiah
force-pushed
the
DOC-12618-Feedback-on-Language-Constructs-Couchbase-Docs
branch
from
ed971c6 to
e89a72f
Compare
|
Ready for another review. 👍🏾 |
AnkitPrabhu
approved these changes
Nov 25, 2024
RayOffiah
deleted the
DOC-12618-Feedback-on-Language-Constructs-Couchbase-Docs
branch
simon-dew
pushed a commit
that referenced
this pull request
Dec 3, 2024
simon-dew
pushed a commit
that referenced
this pull request
Dec 4, 2024
simon-dew
added a commit
that referenced
this pull request
Dec 11, 2024
sarahlwelton
pushed a commit
that referenced
this pull request
Apr 17, 2025
sarahlwelton
pushed a commit
that referenced
this pull request
Apr 17, 2025
sarahlwelton
pushed a commit
that referenced
this pull request
Apr 17, 2025
sarahlwelton
pushed a commit
that referenced
this pull request
May 27, 2025
sarahlwelton
pushed a commit
that referenced
this pull request
May 27, 2025
sarahlwelton
pushed a commit
that referenced
this pull request
May 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pull request:
crc_64_go_iso().