[DOC-12001] Moving some links around to try and resolve the original complaint. #294
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| . (Optional) Create another child field on the new collection type mapping for any additional fields you want to return in your search results. | ||
| + | ||
| For example, you could add the text field that you used to generate your vector embeddings. | ||
| For more information about how to create child fields, see xref:search:create-child-field.adoc[]. |
There was a problem hiding this comment.
Suggested change
| For more information about how to create child fields, see xref:search:create-child-field.adoc[]. |
There was a problem hiding this comment.
I believe this is a repeated sentence? You have this sentence on line 85.
There was a problem hiding this comment.
Nope, I want this here, too, since they need to create another child field in this step, too.
| + | ||
| For more information about how to create type mappings, see xref:search:create-type-mapping.adoc[]. | ||
| . Create a child field mapping on the new collection type mapping: | ||
| .. In the *Field* field, enter the name of the field in your documents that contains your vector embeddings. |
There was a problem hiding this comment.
Suggested change
| .. In the *Field* field, enter the name of the field in your documents that contains your vector embeddings. | |
| .. In *Field*, enter the name of the field in your documents that contains your vector embeddings. |
There was a problem hiding this comment.
The original sentence is fine. I included this in the review because I wanted to try another option to reduce the number of "fields", but again, just a suggestion!
There was a problem hiding this comment.
Yeah I considered that, but then it loses parity with the rest of the sentences and feels strange to me.
There was a problem hiding this comment.
No problem, I'll go approve!
Rebecca-Martinez007
approved these changes
Nov 19, 2024
sarahlwelton
added a commit
that referenced
this pull request
Apr 17, 2025
sarahlwelton
added a commit
that referenced
this pull request
Apr 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not much I can do about the "field" 3 times in a sentence but we're trying out here.