-
Notifications
You must be signed in to change notification settings - Fork 18
DOC-12757 add on deploy #391
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, but for things like this, you might want to think about using Asciidoc description lists instead.
https://docs.asciidoctor.org/asciidoc/latest/lists/description/
|
||
The `OnDeploy` handler runs once when an Eventing function is deployed or resumed. | ||
|
||
The entry point `OnUpdate(action)` receives an `action`, like `deploy` or `resume`, indicating the reason for invocation. It also includes a `delay` value (in milliseconds), representing the time elapsed since the function was paused. For deployment operations, this value is `0` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggesting following correction:
- The entry point
OnUpdate(action)
-> The entry pointOnDeploy(action)
- receives an
action
-> receives anaction
parameter
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done and made the correction
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me from the eventing side! 👍
--------- Co-authored-by: Pallavi-Janardhan <pallavi.janardhan@couchbase.com>
--------- Co-authored-by: Pallavi-Janardhan <pallavi.janardhan@couchbase.com>
--------- Co-authored-by: Pallavi-Janardhan <pallavi.janardhan@couchbase.com>
This PR adds documentation about a new feature, OnDeploy, in the Eventing documentation.
Jira: DOC-12757
Preview: (https://preview.docs-test.couchbase.com/docs-devex-DOC-12757_Add_OnDeploy)
Preview credentials: Preview docs for internal review