Skip to content

Conversation

@rakhi-prathap
Copy link
Contributor

Jira: DOC-11643

This PR adds the following new SQL++ statements.

It also updates two existing statements to include the keywords user/users and group/groups.

Copy link

@dhanyagowrish dhanyagowrish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies, there are several changes that were requested, that were never specified in the DOC ticket description.

Thank you for making the changes!

Copy link
Contributor

@simon-dew simon-dew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry there are such a lot of comments. It's a big PR! This is actually very good; all of my comments are small quibbles.

Co-authored-by: Simon Dew <39966290+simon-dew@users.noreply.github.com>
@simon-dew
Copy link
Contributor

@rakhi-prathap sorry, I just added a new comment to each of the new pages about the :page-status: attribute

rakhi-prathap and others added 8 commits September 4, 2025 08:49
Co-authored-by: Simon Dew <39966290+simon-dew@users.noreply.github.com>
Co-authored-by: Simon Dew <39966290+simon-dew@users.noreply.github.com>
Co-authored-by: Simon Dew <39966290+simon-dew@users.noreply.github.com>
@rakhi-prathap
Copy link
Contributor Author

Sorry there are such a lot of comments. It's a big PR! This is actually very good; all of my comments are small quibbles.

@simon-dew Thanks for the review and sorry about the errors. I've gone through and addressed all your comments.
Do you mind taking another look to see if we're good to merge?

Copy link
Contributor

@simon-dew simon-dew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@rakhi-prathap rakhi-prathap merged commit a6f759d into release/8.0 Sep 24, 2025
6 checks passed
@rakhi-prathap rakhi-prathap deleted the DOC-11643-new-statements branch September 24, 2025 03:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants