[WIP][DOCUMENTATION] Components documentation #215
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for the PR. I'm sorry it took this long
* extend input value proptype to accept numbers * Update input.js
* fix: dropdown close function check if domRef.current In Edge 18, if the dropdown is toggled by an external flag controlled by a click event, the domRef becomes invalid before the event listener is removed, which leads to this.dom.Ref.current.contains to crash. Simply checking for this will result in this.setState being called in an unmounted component. This PR checks if domRef.current exists and only calls this.setState if the domRef is still valid. It also uses mount to test the dropdown state changes. * Update dropdown.js
* fix: remove method on html element IE11 does not support the remove method on HTML elements. This PR implements a recommended way around it. * refactor: do not check if portalElement is a thing on unMount - it always is
kennethnym
changed the title
|
Checks should pass after #216 is merged. |
* Documented domRef prop in README.md * Fixed pagination.js eslint error * Removed .history folder * Removed .history folder in public folder
|
Yes the layout I have in mind is something like that, mimic the bulma documentation to easy navigate. and on the main page of the documentation the different sections. like |
kennethnym
changed the title
* Remove value="" prop from file upload input The value="" prop on the <input type="file"/> component prevented accessing or posting the selected file's contents. * Remove value="" prop from file upload input test snapshot The value="" prop on the <input type="file"/> component prevented accessing or posting the selected file's contents.
* make pagination to be fixed-length * use Math.min and Math.max
* feat: add cross-env to devDependencies and in npm scripts Adding cross-env make scripts work on all paltform. For example, NODE_PATH wasn't working on my OS (Windows). * build: block cross-env dependency to v5.2.0
kennethnym
force-pushed
the
feature/public-page
branch
from
812e8f9 to
ef51340
Compare
|
Closing this PR to clean up the commits. Will reopen as a draft PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure exactly how the design of the documentation should be, but here is the basic layout that I made:
The right side will probably look the same as the official Bulma component documentations.
Am glad to make any changes to the layout. If this design is fine then I'll continue making documentaitons for other components.