-
Notifications
You must be signed in to change notification settings - Fork 4
Pull crawlers #39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Pull crawlers #39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…de a typo and mixed up the 249B description with 249A.... (everything else was quite trivial)
(note: I should probably just refactor the parsing stuff out and write thorough unittests. But that takes so long... ≥_≤)
…t b/c courses actually alias each other heavily and I figured it'd be better to just focus on parsing prereqs first
… courses are linked (roughly...)
…, 20") into good output (ie. "CHEM 1A", "CHEM 1B", "CHEM 1C", "CHEM 20"). The more complex compound cases (ie. "BIOL 20A or CHEM 2 or 3") are already handled, albeit shittily / w/out semantics or grammar parsing...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merged crawler implementation built out in the ucsc-crawler repo