Skip to content

Initial attempt at finding unexecuted files #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 7, 2017
Merged

Initial attempt at finding unexecuted files #39

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
16d122b
Initial attempt at finding unexecuted files
Skeen Mar 12, 2017
3fab4d8
Rename hook, use generator and splitext instead of regex
EmilMagenta Mar 13, 2017
d9f5e1b
Removed enumerate for os.walk, added regex again.
EmilMagenta Mar 13, 2017
a9d274b
Added myself to AUTHORS.txt
EmilMagenta Apr 7, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions AUTHORS.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,3 +4,4 @@ contributions by:
Jessamyn Smith
Simon Charette
Pamela McA'Nulty
Emil Madsen
10 changes: 10 additions & 0 deletions django_coverage_plugin/plugin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
from __future__ import print_function

import os.path
import re
Copy link

@clokep clokep Mar 13, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is now unused.

Copy link
Collaborator

@PamelaM PamelaM Mar 13, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Of course, I've just suggested putting it back (wince)

Copy link

@clokep clokep Mar 13, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops. Missed that conversation, sorry! 👍

Copy link
Collaborator

@PamelaM PamelaM Mar 13, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, my conversation came after your reasonable comment. :)


from six.moves import range

Expand Down Expand Up @@ -162,6 +163,15 @@ def file_tracer(self, filename):
def file_reporter(self, filename):
return FileReporter(filename)

def find_executable_files(self, src_dir):
for (dirpath, dirnames, filenames) in os.walk(src_dir):
for filename in filenames:
# We're only interested in files that look like reasonable HTML
# files: Must end with .htm or .html, and must not have certain
# funny characters that probably mean they are editor junk.
if re.match(r"^[^.#~!$@%^&*()+=,]+\.html?$", filename):
yield os.path.join(dirpath, filename)

# --- FileTracer methods

def has_dynamic_source_filename(self):
Expand Down