Skip to content

Conversation

@PamelaM
Copy link
Collaborator

@PamelaM PamelaM commented Nov 14, 2017

Addresses #44
Django being in install_requires makes it hard for a project using django_coverage_plugin and pip-compile to specify their own version of Django.

  • Remove "Django" from setup.py's install_requires
  • Raise RuntimeError in plugin.py if Django version is lower than 1.8

@PamelaM PamelaM requested a review from nedbat November 15, 2017 13:15
@nedbat
Copy link
Member

nedbat commented Nov 19, 2017

Seems reasonable, but kind of unfortunate. :)

@PamelaM PamelaM merged commit d3b7739 into coveragepy:master Nov 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants