Work with coverage 4.x or 5.x

[nedbat]

@jambonrose This makes it work for both, though it's not nice. I wondered about mocking the creation of the plugins to track which had been made during the test, but I didn't quickly see a way to do that.

Also, I don't know if we should support 4.x and 5.x (which would double the already bulky list of tox environments), or just move to 5?

[jambonrose]

I would be in favor of moving to a v2 plugin that supports:

• Python 3.6+
• Coverage 5+
• Django 2.2+

To ease migration for others, I would advocate ensuring that v1 works with all those versions, and then that we drop support of previous versions of Python/Coverage/Django when we bump the major version of the plugin.

[nedbat]

@jambonrose sounds good to me. One reason I have heard for continuing to support Python 3.5: it's the version installed on a still-supported LTS of Ubuntu: 16.04. But I don't feel strongly about it.

[nedbat]

Also: I should add a supported way to get this information: coveragepy/coveragepy#920

[browniebroke]

I think the build should go green if you update the branch now.

[jambonrose]

@nedbat : That's a good reason to support Python 3.5 . Additionally, I see now that Django 2.2 is also Python 3.5 compatible.

[nedbat]

Updated.

[browniebroke]

I suppose we can now remove the restriction for <5 in setup.py?

https://github.com/nedbat/django_coverage_plugin/blob/46084a2b7c629c4ed458f7804fa43d0307bf9eb1/setup.py#L70

[nedbat]

@jambonrose Is this good to go? Do I merge, or do you?

[Tecktron]

What's the time line on getting this merged?

[jambonrose]

I will look at this tomorrow. Thanks all for your patience.

_{Sent with GitHawk}

[jambonrose]

The test suit for this PR ran with Coverage 4.5.4 .

I think we should:

1. remove the pre-v5 restriction from setup.py
2. update the Read Me to remove the note about Coverage 5
3. run the tests on the CI with Coverage 5

Normally, I'd advocate for updating Tox to run both Coverage 4 and 5, but given our conversation about deprecation and the existing test run on Coverage 4, that feels unnecessary.

[nedbat]

I made those changes.