Skip to content

Conversation

@kaze-cow
Copy link
Contributor

now that foundry has stable releases, there is no reason to subject ourselves to the instability of the nightly releases. this PR proposes locking to the current foundry release v1.3.5, and we can manually bump it as it makes sense.

as it so happens, the current nightly release seems to be changing the lint rules or something and the CI is currently failing with main branch code.

now that foundry has stable releases, there is no reason to subject ourselves to the instability of the nightly releases. this PR proposes
locking to the current foundry release v1.3.5, and we can manually bump it as it makes sense.

as it so happens, the current nightly release seems to be changing the lint rules or something and the CI is currently failing
with `main` branch code.
@kaze-cow kaze-cow self-assigned this Sep 30, 2025
@kaze-cow kaze-cow requested a review from a team as a code owner September 30, 2025 04:39
@kaze-cow kaze-cow added the bug Something isn't working label Sep 30, 2025
@socket-security
Copy link

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Added@​nomicfoundation/​solidity-analyzer-darwin-arm64@​0.1.11001003977100
Added@​nomicfoundation/​solidity-analyzer-darwin-x64@​0.1.11001003977100
Added@​nomicfoundation/​solidity-analyzer-freebsd-x64@​0.1.1881003977100
Added@​nomicfoundation/​solidity-analyzer-linux-arm64-gnu@​0.1.11001003977100
Added@​nomicfoundation/​solidity-analyzer-linux-arm64-musl@​0.1.11001003977100
Added@​nomicfoundation/​solidity-analyzer-linux-x64-gnu@​0.1.11001003977100
Added@​nomicfoundation/​solidity-analyzer-linux-x64-musl@​0.1.11001003977100
Added@​nomicfoundation/​solidity-analyzer-win32-arm64-msvc@​0.1.1881003977100
Added@​nomicfoundation/​solidity-analyzer-win32-ia32-msvc@​0.1.1881003977100
Added@​nomicfoundation/​solidity-analyzer-win32-x64-msvc@​0.1.11001003977100
Addedis-unicode-supported@​0.1.0671007152100
Addedaggregate-error@​3.1.0671008652100
Addedindent-string@​4.0.0671008952100
Addedbabel-helper-optimise-call-expression@​6.24.11001005681100
Addedbabel-helper-get-function-arity@​6.24.11001005781100
Addedis-arrayish@​0.2.11001005883100
Addedghost-testrpc@​0.0.21001005877100
Addedcharenc@​0.0.21001005977100
Addedget-value@​2.0.61001006182100
Addedbabel-helper-regex@​6.26.01001006181100
Addedhome-or-tmp@​2.0.01001006277100
Addedis-finite@​1.1.01001006277100
Addedcopy-descriptor@​0.1.11001006377100
Addedbabel-helper-builder-binary-assignment-operator-visitor@​6.24.11001006381100
Addedhas-ansi@​2.0.01001006483100
Addedcrypt@​0.0.21001006477100
Addedbabel-helper-call-delegate@​6.24.11001006481100
Addedbabel-helper-hoist-variables@​6.24.11001006481100
Addedbabel-helper-explode-assignable-expression@​6.24.11001006581100
Added@​pnpm/​network.ca-file@​1.0.21001006682100
Addedbabel-helper-function-name@​6.24.11001006781100
Added@​pnpm/​config.env-replace@​1.1.01001006781100
Added@​types/​concat-stream@​1.6.01001006777100
See 135 more rows in the dashboard

View full report

@socket-security
Copy link

Warning

Review the following alerts detected in dependencies.

According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.

Action Severity Alert  (click "▶" to expand/collapse)
Warn Critical
babel-traverse@6.26.0 has a Critical CVE.

CVE: GHSA-67hx-6x53-jw92 Babel vulnerable to arbitrary code execution when compiling specifically crafted malicious code (CRITICAL)

Affected versions: >= 0

Patched version: No patched versions

From: yarn.locknpm/babel-plugin-transform-es2015-classes@6.24.1npm/babel-traverse@6.26.0

ℹ Read more on: This package | This alert | What is a critical CVE?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support@socket.dev.

Suggestion: Remove or replace dependencies that include known critical CVEs. Consumers can use dependency overrides or npm audit fix --force to remove vulnerable dependencies.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/babel-traverse@6.26.0. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

Warn Critical
flat@4.1.1 has a Critical CVE.

CVE: GHSA-2j2x-2gpw-g8fm flat vulnerable to Prototype Pollution (CRITICAL)

Affected versions: < 5.0.1

Patched version: 5.0.1

From: yarn.locknpm/eth-gas-reporter@0.2.25npm/flat@4.1.1

ℹ Read more on: This package | This alert | What is a critical CVE?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support@socket.dev.

Suggestion: Remove or replace dependencies that include known critical CVEs. Consumers can use dependency overrides or npm audit fix --force to remove vulnerable dependencies.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/flat@4.1.1. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

View full report

@kaze-cow kaze-cow enabled auto-merge (squash) September 30, 2025 04:41
@kaze-cow kaze-cow merged commit d250714 into main Sep 30, 2025
8 checks passed
@kaze-cow kaze-cow deleted the fix/lock-foundry branch September 30, 2025 07:35
@github-actions github-actions bot locked and limited conversation to collaborators Sep 30, 2025
Copy link
Contributor

@anxolin anxolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants