Skip to content

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Oct 17, 2025

addToken

Note This is an automated PR

Submitted by @presence35

Closes #1185


Adding token aArbUSDCn on network ARBITRUM_ONE

Address: 0x625e7708f30ca75bfd92586e17077590c60eb4cd

Link to block explorer ↗︎

Description Image
Original original
Optimized optimized

Reason

I'm constantly getting Liquidity not found errors for ETH/USDC on Arbitrum.

<img width="789" height="768" alt="Image" src="https://github.com/user-attachments/assets/f20860cd-59b9-4ac2-be90-eb5384ada5b6" />

Summary by CodeRabbit

  • New Features
    • Added support for a new USDC token variant (aArbUSDCn) on Arbitrum network, expanding available token options for users.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 17, 2025

Walkthrough

A new USDC token variant (aArbUSDCn) on Arbitrum is added to the token list. The main CowSwap.json token registry is updated with the token entry, and a corresponding metadata file containing token information and context is created.

Changes

Cohort / File(s) Summary
Token List Update
src/public/CowSwap.json
Added new token entry for aArbUSDCn (USDC) on Arbitrum chain 42161 with address 0x625e7708f30ca75bfd92586e17077590c60eb4cd, 18 decimals, and logo URI
Token Metadata
src/public/images/42161/0x625e7708f30ca75bfd92586e17077590c60eb4cd/info.json
Created new metadata file containing token properties (address, symbol, name, decimals, chainId) and liquidity context documentation

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

The changes consist of a straightforward token entry addition with minimal logic verification needed—only data validation for format, consistency with existing entries, and confirmation that the token details match the linked issue requirements.

Suggested reviewers

  • alfetopito

Poem

🐰 A USDC hops onto Arbitrum's chain,
With address and decimals, clear as day,
The liquidity whispers now ring true,
No more "not found" in ETH trades—
Hop forward, token, we welcome you! 🚀

Pre-merge checks and finishing touches

✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The PR title "[addToken] aArbUSDCn to ARBITRUM_ONE" directly and clearly describes the main change: adding a new token (aArbUSDCn) to the Arbitrum network. The title follows a consistent naming pattern with the [addToken] prefix, is concise and specific enough for a teammate to understand the primary change when scanning history, and accurately represents the modifications present in the changeset.
Linked Issues Check ✅ Passed The changes fully satisfy the requirements from linked issue #1185. All required fields match the specifications: the token symbol (aArbUSDCn), name (USDC), decimals (18), address (0x625e7708f30ca75bfd92586e17077590c60eb4cd), and network (chainId 42161 for Arbitrum) are correctly implemented in the token entry. The info.json file includes the reason field explaining the liquidity-not-found issue, and the logo image is properly hosted in the repository at the specified path. The PR successfully implements the token addition with all requested attributes.
Out of Scope Changes Check ✅ Passed All changes in the PR are directly related to the objective of adding the aArbUSDCn token to Arbitrum as specified in issue #1185. The two modifications consist of adding the token entry to the CowSwap.json token list and creating the corresponding metadata file with token information and context. No extraneous changes, unrelated modifications, or scope creep are present in the changeset.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch addToken/42161_0x625e7708f30ca75bfd92586e17077590c60eb4cd

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@presence35
Copy link

@coderabbitai review

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 17, 2025

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (1)
src/public/CowSwap.json (1)

1924-1931: Consider whether to include the "circle" tag.

Existing USDC entries on Ethereum (line 901) and Arbitrum's official USDC (line 1941) include "tags": ["circle"] to indicate they are Circle-issued tokens. If this aArbUSDCn variant should also be tagged as Circle-issued, add the tags field; otherwise, the omission is fine if this is a separate wrapped/variant token.

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4413f79 and aa50339.

⛔ Files ignored due to path filters (1)
  • src/public/images/42161/0x625e7708f30ca75bfd92586e17077590c60eb4cd/logo.png is excluded by !**/*.png
📒 Files selected for processing (2)
  • src/public/CowSwap.json (1 hunks)
  • src/public/images/42161/0x625e7708f30ca75bfd92586e17077590c60eb4cd/info.json (1 hunks)
🔇 Additional comments (2)
src/public/images/42161/0x625e7708f30ca75bfd92586e17077590c60eb4cd/info.json (1)

6-6: Ensure logo image is available.

Verify that the logo image file exists at the repository path: src/public/images/42161/0x625e7708f30ca75bfd92586e17077590c60eb4cd/logo.png

src/public/CowSwap.json (1)

1924-1931: Verify token entry matches on-chain contract.

The token entry has been added to the registry. Confirm that all details (address, symbol, decimals) match the actual smart contract on Arbitrum at the provided address. The PR description references a block explorer link; ensure this has been validated.

Comment on lines +1 to +10
{
"removed": false,
"address": "0x625e7708f30ca75bfd92586e17077590c60eb4cd",
"symbol": "aArbUSDCn",
"name": "USDC",
"logoURI": "https://raw.githubusercontent.com/cowprotocol/token-lists/main/src/public/images/42161/0x625e7708f30ca75bfd92586e17077590c60eb4cd/logo.png",
"reason": "I'm constantly getting Liquidity not found errors for ETH/USDC on Arbitrum.\n\n<img width=\"789\" height=\"768\" alt=\"Image\" src=\"https://github.com/user-attachments/assets/f20860cd-59b9-4ac2-be90-eb5384ada5b6\" />",
"decimals": 18,
"chainId": 42161
} No newline at end of file
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

🧩 Analysis chain

Verify token address and decimal count on-chain.

The token metadata specifies 18 decimals for a USDC variant (aArbUSDCn), which is unusual since standard USDC uses 6 decimals. While this may be intentional for an Aave-wrapped variant, confirm that address 0x625e7708f30ca75bfd92586e17077590c60eb4cd on Arbitrum actually has 18 decimals by checking the block explorer.


🌐 Web query:

What are the decimal places for token 0x625e7708f30ca75bfd92586e17077590c60eb4cd on Arbitrum?

💡 Result:

The token 0x625e7708f30ca75bfd92586e17077590c60eb4cd (Aave Arbitrum USDC / aArbUSDC) uses 6 decimals. [1]

Sources:
[1] Arbiscan token page for 0x625e7708f30ca75bfd92586e17077590c60eb4cd.


Fix incorrect decimal count for aArbUSDCn token.

The token 0x625e7708f30ca75bfd92586e17077590c60eb4cd on Arbitrum uses 6 decimals, not 18 as currently specified in the metadata. Update the decimals field from 18 to 6.

🤖 Prompt for AI Agents
In src/public/images/42161/0x625e7708f30ca75bfd92586e17077590c60eb4cd/info.json
around lines 1 to 10, the token metadata incorrectly sets "decimals": 18 for
aArbUSDCn (0x625e7708f30ca75bfd92586e17077590c60eb4cd) — change the decimals
value from 18 to 6 to reflect the token's actual 6-decimal precision; update the
JSON field accordingly and validate the file is still valid JSON after the edit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[AddToken] USDC on Arbitrum

2 participants