-
Couldn't load subscription status.
- Fork 28
[addToken] aArbUSDCn to ARBITRUM_ONE
#1186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[addToken] aArbUSDCn to ARBITRUM_ONE
#1186
Conversation
WalkthroughA new USDC token variant (aArbUSDCn) on Arbitrum is added to the token list. The main CowSwap.json token registry is updated with the token entry, and a corresponding metadata file containing token information and context is created. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes The changes consist of a straightforward token entry addition with minimal logic verification needed—only data validation for format, consistency with existing entries, and confirmation that the token details match the linked issue requirements. Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (5 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Nitpick comments (1)
src/public/CowSwap.json (1)
1924-1931: Consider whether to include the "circle" tag.Existing USDC entries on Ethereum (line 901) and Arbitrum's official USDC (line 1941) include
"tags": ["circle"]to indicate they are Circle-issued tokens. If this aArbUSDCn variant should also be tagged as Circle-issued, add the tags field; otherwise, the omission is fine if this is a separate wrapped/variant token.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
src/public/images/42161/0x625e7708f30ca75bfd92586e17077590c60eb4cd/logo.pngis excluded by!**/*.png
📒 Files selected for processing (2)
src/public/CowSwap.json(1 hunks)src/public/images/42161/0x625e7708f30ca75bfd92586e17077590c60eb4cd/info.json(1 hunks)
🔇 Additional comments (2)
src/public/images/42161/0x625e7708f30ca75bfd92586e17077590c60eb4cd/info.json (1)
6-6: Ensure logo image is available.Verify that the logo image file exists at the repository path:
src/public/images/42161/0x625e7708f30ca75bfd92586e17077590c60eb4cd/logo.pngsrc/public/CowSwap.json (1)
1924-1931: Verify token entry matches on-chain contract.The token entry has been added to the registry. Confirm that all details (address, symbol, decimals) match the actual smart contract on Arbitrum at the provided address. The PR description references a block explorer link; ensure this has been validated.
| { | ||
| "removed": false, | ||
| "address": "0x625e7708f30ca75bfd92586e17077590c60eb4cd", | ||
| "symbol": "aArbUSDCn", | ||
| "name": "USDC", | ||
| "logoURI": "https://raw.githubusercontent.com/cowprotocol/token-lists/main/src/public/images/42161/0x625e7708f30ca75bfd92586e17077590c60eb4cd/logo.png", | ||
| "reason": "I'm constantly getting Liquidity not found errors for ETH/USDC on Arbitrum.\n\n<img width=\"789\" height=\"768\" alt=\"Image\" src=\"https://github.com/user-attachments/assets/f20860cd-59b9-4ac2-be90-eb5384ada5b6\" />", | ||
| "decimals": 18, | ||
| "chainId": 42161 | ||
| } No newline at end of file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
Verify token address and decimal count on-chain.
The token metadata specifies 18 decimals for a USDC variant (aArbUSDCn), which is unusual since standard USDC uses 6 decimals. While this may be intentional for an Aave-wrapped variant, confirm that address 0x625e7708f30ca75bfd92586e17077590c60eb4cd on Arbitrum actually has 18 decimals by checking the block explorer.
🌐 Web query:
What are the decimal places for token 0x625e7708f30ca75bfd92586e17077590c60eb4cd on Arbitrum?
💡 Result:
The token 0x625e7708f30ca75bfd92586e17077590c60eb4cd (Aave Arbitrum USDC / aArbUSDC) uses 6 decimals. [1]
Sources:
[1] Arbiscan token page for 0x625e7708f30ca75bfd92586e17077590c60eb4cd.
Fix incorrect decimal count for aArbUSDCn token.
The token 0x625e7708f30ca75bfd92586e17077590c60eb4cd on Arbitrum uses 6 decimals, not 18 as currently specified in the metadata. Update the decimals field from 18 to 6.
🤖 Prompt for AI Agents
In src/public/images/42161/0x625e7708f30ca75bfd92586e17077590c60eb4cd/info.json
around lines 1 to 10, the token metadata incorrectly sets "decimals": 18 for
aArbUSDCn (0x625e7708f30ca75bfd92586e17077590c60eb4cd) — change the decimals
value from 18 to 6 to reflect the token's actual 6-decimal precision; update the
JSON field accordingly and validate the file is still valid JSON after the edit.
addToken
Note This is an automated PR
Submitted by @presence35
Closes #1185
Adding token
aArbUSDCnon networkARBITRUM_ONEAddress:
0x625e7708f30ca75bfd92586e17077590c60eb4cdLink to block explorer ↗︎
Reason
Summary by CodeRabbit