Add README instructions on how to add a new entry #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anxolin
reviewed
Dec 16, 2022
Contributor
anxolin
left a comment
anxolin
left a comment
There was a problem hiding this comment.
Thanks for adding this into the README 🚀
README.md
Outdated
|
|
||
| In order to add a new token to the CoW Swap default token list follow these steps | ||
|
|
||
| - Find an icon with reasonable quality/size (~256px, <100kB). |
Contributor
There was a problem hiding this comment.
Why not exactly 256x256? I think most of the current images in the list (if not all have that size exactly).
@fairlighteth might have some extra-requirements (or different requirements. What is a good process here?
| - Make sure you bump the version using SemVersions | ||
| - Create a PR with these changes | ||
|
|
||
| [^1]: To resize/convert your image [ImageMagick](https://formulae.brew.sh/formula/imagemagick) installed you can simply run `convert ~/Downloads/img.png -resize 256 src/public/images/<chainId>/<address>.png` |
Contributor
There was a problem hiding this comment.
Does this optimize like https://tinypng.com do?
cc/ @fairlighteth
anxolin
reviewed
Dec 16, 2022
alfetopito
approved these changes
Jan 26, 2023
Collaborator
|
Merging as is to have some instructions in the readme. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copying relevant instructions from slack here, so that internal and external contributors can make suggestions (reducing our manual work).