Add Giveth #14
Merged
Add Giveth #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anxolin
reviewed
Dec 16, 2022
Contributor
anxolin
left a comment
anxolin
left a comment
There was a problem hiding this comment.
Looks good, I'm just not sure about the semversioning.
Out of curiosity, did you manage to enable versioning in S3?
| "timestamp": "2022-12-015T19:00:00+00:00", | ||
| "version": { | ||
| "major": 0, | ||
| "major": 1, |
Contributor
There was a problem hiding this comment.
Should we increment major if it's just adding a token?
See https://github.com/Uniswap/token-lists#semantic-versioning
Contributor
Author
There was a problem hiding this comment.
This was rebased on the wrong version of main. The current version is 1.0.0 and so adding a token should just increment the patch to 1.0.1. Will rebase on top of main
| "major": 1, | ||
| "minor": 0, | ||
| "patch": 2 | ||
| "patch": 1 |
Contributor
Author
yes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://cowservices.slack.com/archives/C04DV3TL1MH/p1671036044310869