Skip to content

Prevent spaces in token symbols #169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 18, 2023
Merged

Prevent spaces in token symbols #169

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
22a3bb6
Added description about not using token symbols
alfetopito Apr 18, 2023
05d7b74
Failing validation if token symbol contains spaces
alfetopito Apr 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/ISSUE_TEMPLATE/addTokenForm.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ body:
id: symbol
attributes:
label: Token Symbol
description: The token symbol should not contain spaces
placeholder: SYMBOL
validations:
required: true
Expand Down
6 changes: 6 additions & 0 deletions .github/workflows/processRequest.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,6 +126,12 @@ jobs:
echo "${{ env.NETWORK }} ${{ env.URL }} ${{ env.ADDRESS }}"
echo "::error title={Validation failed}::{Missing required fields for adding a token}"
exit 1
- name: Validate symbol
if: env.SYMBOL
run: |
validate_symbol=$(echo ${{ env.SYMBOL }} | grep '\s' -qE)
validate_symbol && echo "::error title={Validation failed}::{Symbol cannot contain spaces}"
exit validate_symbol
- name: Validate removeToken
if: contains(github.event.issue.labels.*.name, 'removeToken') && (!env.NETWORK || !env.REASON || !env.ADDRESS)
run: |
Expand Down