Add alUSD #17
Merged
Add alUSD #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fleupold
reviewed
Dec 19, 2022
Contributor
fleupold
left a comment
fleupold
left a comment
There was a problem hiding this comment.
Looks good to me, just needs the version bump.
src/public/CowSwap.json
Outdated
| "major": 1, | ||
| "minor": 0, | ||
| "patch": 1 | ||
| "major": 0, |
Contributor
There was a problem hiding this comment.
This should bump minor version by one from the current version (https://files.cow.fi/tokens/CowSwap.json), to 1.2.0
Contributor
Author
|
This should bump minor version by one from the current version (
https://files.cow.fi/tokens/CowSwap.json), to 1.2.0
Hi. Thanks for the review and comment. Please bear with my ignorance. Does
your comment mean that I need to change the version bump text that I
edited? Based on what I read, I interpreted it as when a token is added,
"minor" value should be 1. I guess I mis-interpreted how it works. Should I
change it to 1, 2, 0 for major, minor, and patch, respectively?
Many thanks
…On Mon, Dec 19, 2022 at 4:04 AM Felix Leupold ***@***.***> wrote:
***@***.**** commented on this pull request.
Looks good to me, just needs the version bump.
------------------------------
In src/public/CowSwap.json
<#17 (comment)>
:
> @@ -2,9 +2,9 @@
"name": "CoW Swap",
"timestamp": "2022-12-15T19:00:00+00:00",
"version": {
- "major": 1,
- "minor": 0,
- "patch": 1
+ "major": 0,
This should bump minor version by one from the current version (
https://files.cow.fi/tokens/CowSwap.json), to 1.2.0
—
Reply to this email directly, view it on GitHub
<#17 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AX53K6SSWUMARYR4CFV53TDWOAQIDANCNFSM6AAAAAATCYGWSI>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Contributor
|
I merged main and fixed the versioning. Change is deployed Check it out: |
Contributor
Author
|
Thank you so much! I think I'm finally understanding how the versioning
works. Again, thanks for bearing with me and for your help!
…On Mon, Dec 19, 2022 at 9:40 AM Felix Leupold ***@***.***> wrote:
I merged main and fixed the versioning. Change is deployed
Check it out:
[image: image]
<https://user-images.githubusercontent.com/1200333/208450639-189a9c94-2960-4a58-94db-5151f0823936.png>
—
Reply to this email directly, view it on GitHub
<#17 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AX53K6VALAMJBJVZE2VIBT3WOBXWLANCNFSM6AAAAAATCYGWSI>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added alUSD per the instructions that were sent. Hopefully, I've done this correctly. Thanks